Conversation
…8492) In order to simplify our fly.io deployment and rely on zero's built-in litestream configuration instead of maintaining our own, this PR removes the custom `[[files]]` litestream config sections from both the replication manager and view syncer templates. Zero already supports `ZERO_LITESTREAM_ENDPOINT` for non-AWS S3 endpoints (like Cloudflare R2), and its default config handles the metrics `addr` (port+2 = 4850), replica path, bucket, and auth via `AWS_ACCESS_KEY_ID`/`AWS_SECRET_ACCESS_KEY` fly secrets. The only thing we needed to add was the `ZERO_LITESTREAM_ENDPOINT` env var so zero knows the R2 endpoint URL. Also enables multinode deployment for previews so the replication manager + view syncer templates are actually tested in preview deploys (previously previews used single-node which doesn't have litestream at all). ### Change type - [x] `improvement` ### Test plan 1. Deploy preview with `dotcom-preview-please` + `preview-flyio-zero-deploy-please` labels (now multinode) 2. Check `flyctl logs` for litestream errors (endpoint resolution, auth failures) 3. Verify backup files appear in Cloudflare R2 bucket at the expected path 4. Confirm changelog draining: `SELECT pg_size_pretty(pg_total_relation_size('zero."changeLog"'));` stays small 5. Verify backup-monitor logs show successful watermark determination ### Release notes - Remove custom litestream configuration from zero fly.io deployments in favor of zero's built-in defaults ### Code changes | Section | LOC change | | ------- | ---------- | | Apps | +2 / -32 | | Config/tooling | +5 / -8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )